Module talk:Armor

Compatibility
Summary of the issues encountered: The fixes for 1 and 3 seem fine to me, the workaround for 2 feels rather crude to me. For 5, the solution could be to store the upgrade data for TotK on a separate page (maybe a  page?) but this would need a 2nd crude workaround. Another would be to modify the restriction on StoreAs, perhaps changing it from one table to one table per game, if that's possible? Third would be to rework how the module stores and retrieves data so that BotW data and TotK data are separate in cargo but both handled by this module. However, until the upgrade data is complete or a solution for 4 is found, the optimal solution to 5 seems to be a moot point. 15:31, 2 June 2023 (UTC)
 * 1) module has a game parameter but only actually supports BotW (previous fix)
 * 2) module only allows data from Armor and Armor Upgrade
 * 3) *TotK Armor is stored on Armor in Tears of the Kingdom (previous workaround)
 * 4) while using Armor Data to retrieve upgrade information, the Cargo query doesn't check which game the data is from
 * 5) * would return BotW upgrade data if available (previous fix, same edit as in previous point)
 * 6) Storing to cargo has weird behaviour if Sell Price column has an empty value
 * 7) *Storage of that row fails and any edit, even null edits, cause duplication of data in the Cargo table
 * 8) **Consequently, the previous fixes were removed while identifying this issue
 * 9) Upgrade data for TotK's Armor is not being stored due to the restriction on Data Table's StoreAs parameter, the module's storeUpgrade function automatically sets this as Armor